Add more keys to XHR feature #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
autonome
approved these changes
Oct 15, 2024
|
Stepping a bit on each other's toes here and in #1982 (comment). My own review would apply here as well 😄 |
Merged
haha yes ok so i'll remove XHR keys from my patch and just do the fetch bits so you can do XHR here. |
captainbrosset
approved these changes
Oct 18, 2024
|
|
||
| # baseline: high | ||
| # baseline_low_date: 2018-10-02 | ||
| # baseline_high_date: 2021-04-02 |
There was a problem hiding this comment.
These new formdata keys became baseline hight quite a bit later than the other keys already in there. But they're still old enough that this shouldn't matter.
Added the keys I found in 12a84b3 |
autonome
approved these changes
Oct 21, 2024
ddbeck
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and delete the draft file.
The original PR was #1155. I'm not sure why these keys weren't included, maybe oversight. We should map them somewhere and I think they could belong here.