Skip to content

Add more keys to XHR feature #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Add more keys to XHR feature #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bf1ad8
Add more keys to XHR feature
Elchi3 Oct 14, 2024
7d6a9bd
Merge branch 'main' into more-xhr
autonome Oct 15, 2024
12a84b3
moar keys
Elchi3 Oct 18, 2024
e263d09
Merge branch 'main' into more-xhr
Elchi3 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions features/draft/spec/xhr.yml
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions features/draft/spec/xhr.yml.dist
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions features/xhr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ compat_features:
- api.FormData
- api.FormData.append
- api.FormData.append.filename_parameter
- api.FormData.delete
- api.FormData.get
- api.FormData.getAll
- api.FormData.has
- api.FormData.set
- api.FormData.FormData
- api.ProgressEvent
- api.ProgressEvent.ProgressEvent
- api.ProgressEvent.lengthComputable
- api.ProgressEvent.loaded
- api.ProgressEvent.total
Expand All @@ -20,6 +26,7 @@ compat_features:
- api.XMLHttpRequest.abort_event
- api.XMLHttpRequest.error_event
- api.XMLHttpRequest.getAllResponseHeaders
- api.XMLHttpRequest.getAllResponseHeaders.header_names_lowercase
- api.XMLHttpRequest.getResponseHeader
- api.XMLHttpRequest.load_event
- api.XMLHttpRequest.loadend_event
Expand All @@ -31,12 +38,19 @@ compat_features:
- api.XMLHttpRequest.readystatechange_event
- api.XMLHttpRequest.response
- api.XMLHttpRequest.responseText
- api.XMLHttpRequest.responseType
- api.XMLHttpRequest.responseType.arraybuffer_value
- api.XMLHttpRequest.responseType.blob_value
- api.XMLHttpRequest.responseType.document_value
- api.XMLHttpRequest.responseType.json_value
- api.XMLHttpRequest.responseURL
- api.XMLHttpRequest.responseXML
- api.XMLHttpRequest.send
- api.XMLHttpRequest.send.body_ArrayBuffer_type
- api.XMLHttpRequest.send.body_ArrayBufferView_type
- api.XMLHttpRequest.send.body_Blob_type
- api.XMLHttpRequest.send.body_FormData_type
- api.XMLHttpRequest.send.body_URLSearchParams_type
- api.XMLHttpRequest.setRequestHeader
- api.XMLHttpRequest.status
- api.XMLHttpRequest.statusText
Expand Down
110 changes: 110 additions & 0 deletions features/xhr.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,116 @@ compat_features:
- api.XMLHttpRequest.timeout_event
- api.XMLHttpRequestUpload.timeout_event

# baseline: high
# baseline_low_date: 2016-08-02
# baseline_high_date: 2019-02-02
# support:
# chrome: "16"
# chrome_android: "18"
# edge: "14"
# firefox: "18"
# firefox_android: "18"
# safari: "6"
# safari_ios: "6"
- api.ProgressEvent.ProgressEvent

# baseline: high
# baseline_low_date: 2016-08-02
# baseline_high_date: 2019-02-02
# support:
# chrome: "37"
# chrome_android: "37"
# edge: "14"
# firefox: "32"
# firefox_android: "32"
# safari: "8"
# safari_ios: "8"
- api.XMLHttpRequest.responseURL

# baseline: high
# baseline_low_date: 2016-11-15
# baseline_high_date: 2019-05-15
# support:
# chrome: "31"
# chrome_android: "31"
# edge: "12"
# firefox: "6"
# firefox_android: "50"
# safari: "5.1"
# safari_ios: "5"
- api.XMLHttpRequest.responseType
- api.XMLHttpRequest.responseType.arraybuffer_value
- api.XMLHttpRequest.responseType.blob_value

# baseline: high
# baseline_low_date: 2016-11-15
# baseline_high_date: 2019-05-15
# support:
# chrome: "31"
# chrome_android: "31"
# edge: "12"
# firefox: "11"
# firefox_android: "50"
# safari: "7"
# safari_ios: "7"
- api.XMLHttpRequest.responseType.document_value

# baseline: high
# baseline_low_date: 2018-10-02
# baseline_high_date: 2021-04-02
Copy link
Contributor

@captainbrosset captainbrosset Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new formdata keys became baseline hight quite a bit later than the other keys already in there. But they're still old enough that this shouldn't matter.

# support:
# chrome: "50"
# chrome_android: "50"
# edge: "18"
# firefox: "39"
# firefox_android: "39"
# safari: "11.1"
# safari_ios: "11.3"
- api.FormData.delete
- api.FormData.get
- api.FormData.getAll
- api.FormData.has
- api.FormData.set

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "31"
# chrome_android: "31"
# edge: "79"
# firefox: "10"
# firefox_android: "50"
# safari: "7"
# safari_ios: "7"
- api.XMLHttpRequest.responseType.json_value

# baseline: high
# baseline_low_date: 2020-01-15
# baseline_high_date: 2022-07-15
# support:
# chrome: "60"
# chrome_android: "60"
# edge: "79"
# firefox: "64"
# firefox_android: "64"
# safari: "11"
# safari_ios: "11"
- api.XMLHttpRequest.getAllResponseHeaders.header_names_lowercase

# baseline: high
# baseline_low_date: 2021-09-20
# baseline_high_date: 2024-03-20
# support:
# chrome: "59"
# chrome_android: "59"
# edge: "17"
# firefox: "44"
# firefox_android: "44"
# safari: "15"
# safari_ios: "15"
- api.XMLHttpRequest.send.body_URLSearchParams_type

# baseline: false
# support:
# firefox: "54"
Expand Down