Simplify and document the dist generation flow #1233
Conversation
Parts of this were more complicated than they need to be because initially the dist file was a modified version of the source with comments preserved. Now that it is just computed data, simplifications are possible. Also, only call computeBaseline once with the compat keys that will actually be used. This does mean that fixing one warning could reveal another instead of showing both at the same time, but that's not so awful.
| - css.properties.bottom.anchor | ||
| - css.properties.height.anchor-size | ||
| - css.properties.inline-size.anchor-size | ||
| - css.properties.inset.anchor |
There was a problem hiding this comment.
@ddbeck would you like me to do extra work to tweak the sort order so that "." is sorted before "-"?
There was a problem hiding this comment.
It would be nice to have but #1231 will eventually make this sort order irrelevant, right? Or at least it's a problem for that code?
There was a problem hiding this comment.
Right... I was thinking #1231 would only group things but not change the order, but actually it will be quite natural only order the keys that we're going to write to dist, and approach it more as "nice visual display order" and not "canonicalize for isDeepStrictEqual". Details TBD, but I think you're right it's fine to solve this problem there, if the order feels ugly after breaking up into blocks.
| - css.properties.bottom.anchor | ||
| - css.properties.height.anchor-size | ||
| - css.properties.inline-size.anchor-size | ||
| - css.properties.inset.anchor |
There was a problem hiding this comment.
It would be nice to have but #1231 will eventually make this sort order irrelevant, right? Or at least it's a problem for that code?
foolip
changed the title
2 participants
Parts of this were more complicated than they need to be because
initially the dist file was a modified version of the source with
comments preserved. Now that it is just computed data, simplifications
are possible.
Also, only call computeBaseline once with the compat keys that will
actually be used. This does mean that fixing one warning could reveal
another instead of showing both at the same time, but that's not so
awful.