- 
                Notifications
    You must be signed in to change notification settings 
- Fork 193
Introduce compute_from to pin a feature's status to BCD key(s) #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| There are things I'd like to improve here still, but this shows the promise of it. | 
b1644b5    to
    761b718      
    Compare
  
    | For @captainbrosset and anyone else following along: The idea here is to let us pick a subset of a feature's compat keys to compute the Baseline status from. Applications for this would be, for example, to: 
 In general, this would let us associate more keys with features without minting¹ new features or moving a feature's Baseline low date upon later additions. Accepting this PR would depend on accepting #1204, too, so that consumers could show the most-correct status for a given slice of a feature. Discussion relating to this idea comes mostly from #1160 and (to a lesser extent) #866 and a few (regrettably unrecorded) conversations between Philip and myself. ¹ but it also doesn't foreclose on later minting features, by cleaving keys off an existing feature (@foolip please correct me if I've mischaracterized anything here) | 
| @ddbeck that is well summarized, thank you. The main use case for this is to "lock" a feature's support status to its entrypoint(s), so that a feature that when a feature evolves the Baseline date doesn't keep moving forward. | 
675871a    to
    7b65352      
    Compare
  
    7b65352    to
    e058f5b      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this, but I have one straggling thought and a request to preserve comments. Thank you!
57a7c42    to
    dd662a9      
    Compare
  
    abcc25d    to
    7eb5091      
    Compare
  
    A bunch of features are updates to show this in action. Most features have a single entrypoint, but compressions streams has two, exercising the case when compute_from is an array.
7eb5091    to
    9620200      
    Compare
  
    
No description provided.