Skip to content

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Jun 10, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jun 10, 2024
@foolip foolip requested a review from ddbeck June 10, 2024 16:08
@foolip
Copy link
Collaborator Author

foolip commented Jun 10, 2024

There are things I'd like to improve here still, but this shows the promise of it.

@foolip foolip force-pushed the status-compute-from branch from b1644b5 to 761b718 Compare June 11, 2024 06:25
@ddbeck
Copy link
Collaborator

ddbeck commented Jun 11, 2024

For @captainbrosset and anyone else following along:

The idea here is to let us pick a subset of a feature's compat keys to compute the Baseline status from. Applications for this would be, for example, to:

  • Align a feature to caniuse's reported availability
  • Capture a feature's interoperable date despite minor additions to that feature
  • Ignore specific faulty/weird/complex/missing keys in BCD while still maintaining a connection to the underlying data

In general, this would let us associate more keys with features without minting¹ new features or moving a feature's Baseline low date upon later additions. Accepting this PR would depend on accepting #1204, too, so that consumers could show the most-correct status for a given slice of a feature.

Discussion relating to this idea comes mostly from #1160 and (to a lesser extent) #866 and a few (regrettably unrecorded) conversations between Philip and myself.

¹ but it also doesn't foreclose on later minting features, by cleaving keys off an existing feature

(@foolip please correct me if I've mischaracterized anything here)

@foolip
Copy link
Collaborator Author

foolip commented Jun 24, 2024

@ddbeck that is well summarized, thank you. The main use case for this is to "lock" a feature's support status to its entrypoint(s), so that a feature that when a feature evolves the Baseline date doesn't keep moving forward.

@foolip foolip force-pushed the status-compute-from branch 2 times, most recently from 675871a to 7b65352 Compare June 24, 2024 14:38
@foolip
Copy link
Collaborator Author

foolip commented Jun 24, 2024

@ddbeck I'd like to document how to use compat_features but I'm not sure where. See #1159.

@foolip foolip force-pushed the status-compute-from branch from 7b65352 to e058f5b Compare June 24, 2024 14:41
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, but I have one straggling thought and a request to preserve comments. Thank you!

@foolip foolip force-pushed the status-compute-from branch 4 times, most recently from 57a7c42 to dd662a9 Compare July 1, 2024 15:41
@foolip foolip force-pushed the status-compute-from branch 3 times, most recently from abcc25d to 7eb5091 Compare July 1, 2024 17:00
A bunch of features are updates to show this in action. Most features
have a single entrypoint, but compressions streams has two, exercising
the case when compute_from is an array.
@foolip foolip force-pushed the status-compute-from branch from 7eb5091 to 9620200 Compare July 1, 2024 17:14
@foolip foolip merged commit 75b1568 into web-platform-dx:main Jul 1, 2024
@foolip foolip deleted the status-compute-from branch July 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants