Make the dist script crawl all features by default #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
The "**" path pattern in package.json doesn't work on at least macOS, and contributed to an orphaned dist file: web-platform-dx#1205. To avoid such issues, let the command expand directory names to any dist files within, and make the dist script crawl all features by default. This also allows simplifiying instructions in a README.
foolip
force-pushed
the
dist-default-paths
branch
from
17dc41a to
2e463bb
Compare
foolip
changed the title
|
This leaves in the check from #1209 since that also provides a clear error message. |
ddbeck
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "**" path pattern in package.json doesn't work on at least macOS,
and contributed to an orphaned dist file:
#1205.
To avoid such issues, let the command expand directory names to any dist
files within, and make the dist script crawl all features by default.
This also allows simplifiying instructions in a README.