Catch orphaned dist files during --check
#1209
Conversation
| computeBaseline, | ||
| setLogger, | ||
| } from "compute-baseline"; | ||
| import { computeBaseline, setLogger } from "compute-baseline"; |
There was a problem hiding this comment.
Oh oops, my editor removed these unused imports. I can move this to a separate PR, if desired.
| filePath = filePath.substring(0, filePath.length - 5); | ||
| const candidateFilePath = filePath.substring(0, filePath.length - 5); | ||
|
|
||
| // Make sure this isn't an orphan dist file |
There was a problem hiding this comment.
Maybe I should use a different word here? "Orphan catching" sounds truly Dickensian
There was a problem hiding this comment.
I think the terminology is OK, it's not as funny as https://html.spec.whatwg.org/multipage/parsing.html#adoption-agency-algorithm, but still OK.
I'll land this and rebase #1210 on top, and I suspect this comment will disappear anyway.
| filePath = filePath.substring(0, filePath.length - 5); | ||
| const candidateFilePath = filePath.substring(0, filePath.length - 5); | ||
|
|
||
| // Make sure this isn't an orphan dist file |
There was a problem hiding this comment.
I think the terminology is OK, it's not as funny as https://html.spec.whatwg.org/multipage/parsing.html#adoption-agency-algorithm, but still OK.
I'll land this and rebase #1210 on top, and I suspect this comment will disappear anyway.
2 participants
This prevents
.distfiles from hanging around even after the authored YAML has been deleted.Inspired by #1205