Skip to content

Reword Vue instance/application parameters mentions #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 1, 2020
Merged

Reword Vue instance/application parameters mentions #355

merged 6 commits into from
Aug 1, 2020

Conversation

NataliaTepluhina
Copy link
Member

This PR applies a set of fixes for the issues described on #345

  • Changes names for options passed to createApp
  • Changes Vue instance to application/root/component/active instance depending on context
  • Removed an excessive provide/inject section

@NataliaTepluhina NataliaTepluhina linked an issue Jul 29, 2020 that may be closed by this pull request
Applications, root components and Vue instances #345
Closed
@NataliaTepluhina NataliaTepluhina changed the title Reworn Vue instance/application parameters Reword Vue instance/application parameters mentions Jul 29, 2020
@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 29, 2020
bencodezen
bencodezen approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredibly detailed. Love the changes and improvements to make it clearer to users how things should be used or might be affected. 👍

@bencodezen bencodezen merged commit 3f66e80 into master Aug 1, 2020
@NataliaTepluhina NataliaTepluhina deleted the fix-vue-instance branch August 3, 2020 04:41
@skirtles-code skirtles-code mentioned this pull request Aug 16, 2020
Merged
alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this pull request Apr 1, 2024
@Hekikai
feat: translate faq.md (vuejs#355)
bf9a8de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodezen bencodezen bencodezen approved these changes

@sdras sdras Awaiting requested review from sdras

@phanan phanan Awaiting requested review from phanan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applications, root components and Vue instances
2 participants
@NataliaTepluhina @bencodezen