Skip to content

Add app.provide to the API reference #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2020

Conversation

skirtles-code
Copy link
Contributor

This PR addresses problems raised in #406. Specifically:

  1. Minor corrections to an example of app.provide in the migration guide.
  2. Adding documentation for app.provide to the API reference. This had been documented previously but the majority of the text described the wrong feature so it was removed in Reword Vue instance/application parameters mentions #355. I have retained some small parts of that previous entry but the majority is new.

I believe it would also be beneficial to mention app.provide elsewhere in the documentation, such as in the introductory guide to provide/inject and in the API reference section for the provide & inject options. I haven't undertaken that as part of this PR but I would be happy to attempt it if you feel it would be appropriate.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirtles-code thank you, this is a great addition! 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit d7b4cc8 into vuejs:master Aug 16, 2020
@skirtles-code skirtles-code deleted the app-provide branch August 16, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants