Skip to content

Conversation

potato4d
Copy link
Member

@potato4d potato4d commented Oct 8, 2020

Description of Problem

  • TextLint が CI で設定されておらず、Lintエラーのまま lang-ja に入っている項目があった

Proposed Solution

  • Lint を GitHub Actions で実行し、事前に防げる状態にした
  • あわせて、既にあるエラーはこの PR にて全て修正しておくことにした
    • 修正を含めない場合、今後修正を入れるまで CI が落ち続けるため

Additional Information

@netlify
Copy link

netlify bot commented Oct 8, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit b0046c7

https://deploy-preview-103--vuejs-v3-ja-doc-preview.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 3da4466

https://deploy-preview-103--vuejs-v3-ja-doc-preview.netlify.app

@potato4d potato4d requested a review from kazupon October 8, 2020 14:45
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
マージしますね!

@kazupon kazupon merged commit 2a855f5 into lang-ja Oct 8, 2020
@kazupon kazupon deleted the chore/install-ci branch October 8, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants