Skip to content

[Misc] Clean up scatter_patch_features #15559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

[Misc] Clean up scatter_patch_features #15559

merged 2 commits into from
Mar 27, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 26, 2025 •
edited by github-actions bot
Loading

Make the arguments to scatter_patch_features have the same leading dimension, removing the need to use v0_path which is quite hacky. This is to facilitate #15487

Test status (using tests/models/decoder_only/vision_language):

V0 V1
Gemma 3 ✅︎ ✅︎
InternVL ✅︎ ✅︎
Molmo ✅︎ ✅︎
Pixtral ✅︎ ✅︎
Pixtral-HF ✅︎ ✅︎

@DarkLight1337 DarkLight1337 requested a review from ywang96 March 26, 2025 17:24
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Fix gemma3
6c033ae 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 27, 2025
@DarkLight1337 DarkLight1337 marked this pull request as ready for review March 27, 2025 04:24
@DarkLight1337
Copy link
Member Author

The tests pass for all updated models.

@DarkLight1337 DarkLight1337 added the multi-modality Related to multi-modality (#4194) label Mar 27, 2025
Isotr0py
Isotr0py approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Isotr0py Isotr0py enabled auto-merge (squash) March 27, 2025 05:11
@Isotr0py Isotr0py merged commit e6c9053 into vllm-project:main Mar 27, 2025
39 checks passed
@DarkLight1337 DarkLight1337 deleted the cleanup-scatter-patch-features branch March 27, 2025 08:30
This was referenced Mar 27, 2025
Merged
Closed
Merged
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@DarkLight1337 @Alex4210987
[Misc] Clean up scatter_patch_features (vllm-project#15559)
9996a8b 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Misc] Clean up scatter_patch_features (vllm-project#15559)
8b8e4cc 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Misc] Clean up scatter_patch_features (vllm-project#15559)
3c22242 
Signed-off-by: DarkLight1337 <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Misc] Clean up scatter_patch_features (vllm-project#15559)
3cadd4a 
Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Misc] Clean up scatter_patch_features (vllm-project#15559)
a3f2cc5 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees
No one assigned
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @jeejeelee @Isotr0py