Skip to content

[Model] MiniCPM-V/O supports V1 #15487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 27, 2025
Merged

[Model] MiniCPM-V/O supports V1 #15487

merged 21 commits into from
Mar 27, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 25, 2025 •
edited
Loading

Also push a fix for Molmo (I forgot to push it to #15559)

  • Implement for MiniCPM-V
  • Implement for MiniCPM-O
  • Auto-generate embed_is_patch for embedding inputs
  • Pass the tests on V0
  • Pass the tests on V1

cc @HwwwwwwwH @ywang96

@DarkLight1337
[WIP] MiniCPM-V/O supports V1
10dffe2 
Signed-off-by: DarkLight1337 <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Mar 25, 2025
Closed
5 tasks
@DarkLight1337 DarkLight1337 self-assigned this Mar 25, 2025
@DarkLight1337 DarkLight1337 moved this to In Progress in Multi-modality Core Mar 25, 2025
@DarkLight1337
Merge branch 'main' into minicpm-v1
64a8a85
@DarkLight1337
Update
9e6cbc4 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Fix
f4045a3 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
0797fe3 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
e0bc437 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
51be0e6 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Set mm_orders for both normal and embedding inputs
b477a3b 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [WIP] MiniCPM-V/O supports V1 [Model] MiniCPM-V/O supports V1 Mar 26, 2025
@DarkLight1337
Update
74ace59 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Fix token counts
f9341af 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
eecd456 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
6c36c41 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Fix
4fe0b32 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Handle embedding inputs
d7beed7 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 26, 2025
Merged
@DarkLight1337
Merge branch 'main' into minicpm-v1
a49d975
@DarkLight1337
Update
fc7bd77 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Fix Molmo
38168fb 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Pass pre-commit
901a5f4 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Fix
4df0785 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update docs
48bed71 
Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 27, 2025
@DarkLight1337 DarkLight1337 requested a review from jeejeelee March 27, 2025 10:19
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 27, 2025 10:19
@DarkLight1337 DarkLight1337 marked this pull request as ready for review March 27, 2025 10:19
@DarkLight1337
Copy link
Member Author

Tests pass now

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 27, 2025
Isotr0py
Isotr0py approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minicpmo multi-image tests passed locally as well, so LGTM!

@DarkLight1337
Remove unnecessary conversion
6cbd9f0 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member Author

The tests passed in the previous commit so I'll force merge this once pre-commit and docs pass

@vllm-bot vllm-bot merged commit ac5bc61 into vllm-project:main Mar 27, 2025
10 of 13 checks passed
@DarkLight1337 DarkLight1337 deleted the minicpm-v1 branch March 27, 2025 13:07
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multi-modality Core Mar 27, 2025
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 27, 2025
Open
53 tasks
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@DarkLight1337 @Alex4210987
[Model] MiniCPM-V/O supports V1 (vllm-project#15487)
fe9455d 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Model] MiniCPM-V/O supports V1 (vllm-project#15487)
6859fad 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Model] MiniCPM-V/O supports V1 (vllm-project#15487)
fb274e9 
Signed-off-by: DarkLight1337 <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Model] MiniCPM-V/O supports V1 (vllm-project#15487)
2d7700c 
Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Model] MiniCPM-V/O supports V1 (vllm-project#15487)
b146aec 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@jeejeelee jeejeelee Awaiting requested review from jeejeelee

Assignees

@DarkLight1337 DarkLight1337

Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
Multi-modality Core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot