Skip to content

Conversation

vllmellm
Copy link
Contributor

@vllmellm vllmellm commented Mar 12, 2025

This pull request addresses the compilation error encountered when building the latest vLLM commit on ROCm. The issue arises from the compilation of CUDA-only kernels introduced in commit 90e88ab. Specifically, the error occurs during the compilation of moe_wna16.cu.

Changes:

  • Compile moe_wna16_gemm for non-ROCm architectures only.

FIX #14669

Signed-off-by: vllmellm <[email protected]>
@vllmellm vllmellm requested a review from tlrmchlsmth as a code owner March 12, 2025 09:24
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@vllmellm vllmellm changed the title [ROCM][BUG] Fix Compilation Error for CUDA Kernels on ROCm [Rocm][Bugfix] Fix Compilation Error for CUDA Kernels on ROCm Mar 12, 2025
@mergify mergify bot added the ci/build label Mar 12, 2025
@vllmellm vllmellm changed the title [Rocm][Bugfix] Fix Compilation Error for CUDA Kernels on ROCm [Rocm][Bugfix] Fix ROCm build failiure Mar 12, 2025
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 12, 2025
Signed-off-by: vllmellm <[email protected]>
@vllmellm vllmellm changed the title [Rocm][Bugfix] Fix ROCm build failiure [ROCm][Bugfix] Fix ROCm build failiure Mar 12, 2025
@vllmellm vllmellm changed the title [ROCm][Bugfix] Fix ROCm build failiure [ROCm][Bugfix] Fix ROCm build failure Mar 12, 2025
Signed-off-by: vllmellm <[email protected]>
Signed-off-by: vllmellm <[email protected]>
@tjtanaa
Copy link
Contributor

tjtanaa commented Mar 12, 2025

@DarkLight1337 Please close this PR as it is resolved in #14629

Copy link

mergify bot commented Mar 12, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @vllmellm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ROCm fail to build due to compilation error of moe_wna16.cu

3 participants