-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ROCm][Bugfix] Ensure that the moe_wna16_gemm kernel is not built on ROCm platforms. #14629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm][Bugfix] Ensure that the moe_wna16_gemm kernel is not built on ROCm platforms. #14629
Conversation
Signed-off-by: Sage Moore <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Confirming that this fixes the build. Thanks! |
Signed-off-by: Sage Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Sage, LGTM. I think this kernels works on SM 70/75 so we should loosing the restriction later cc @jinzhen-lin but let's get the fix in now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a build test to cover such case in the follow up PR?
Ideally, this should be caught by CI directly.
This is needed to fix ROCm build issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it fixed my build issue
I agree. |
Looks like the AMD job was not run on #13321 which is why the build error slipped through the cracks. Unfortunately, the AMD job has been red for quite some time and we don't want to add additional noise to inflight PRs. We've made decent strides towards getting that build green, but there's more work to do. If you are interested in contributing to this effort, feel free to reach out to me on the vllm slack and I can provide some more context. There's nothing really hard here, we just need to grind through all of the failures. |
…ROCm platforms. (vllm-project#14629) Signed-off-by: Sage Moore <[email protected]> Signed-off-by: Richard Liu <[email protected]>
…ROCm platforms. (vllm-project#14629) Signed-off-by: Sage Moore <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…ROCm platforms. (vllm-project#14629) Signed-off-by: Sage Moore <[email protected]>
…ROCm platforms. (vllm-project#14629) Signed-off-by: Sage Moore <[email protected]> Signed-off-by: Mu Huai <[email protected]>
See above. This kernel was introduced in #13321.