Skip to content

Conversation

SageMoore
Copy link
Contributor

@SageMoore SageMoore commented Mar 11, 2025

See above. This kernel was introduced in #13321.

Signed-off-by: Sage Moore <[email protected]>
@SageMoore SageMoore requested a review from tlrmchlsmth as a code owner March 11, 2025 17:20
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 11, 2025
@gshtras
Copy link
Collaborator

gshtras commented Mar 11, 2025

Confirming that this fixes the build. Thanks!

Signed-off-by: Sage Moore <[email protected]>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sage, LGTM. I think this kernels works on SM 70/75 so we should loosing the restriction later cc @jinzhen-lin but let's get the fix in now

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a build test to cover such case in the follow up PR?

Ideally, this should be caught by CI directly.

@hongxiayang hongxiayang added the rocm Related to AMD ROCm label Mar 11, 2025
@hongxiayang
Copy link
Collaborator

This is needed to fix ROCm build issue

Copy link
Collaborator

@hongxiayang hongxiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fixed my build issue

@hongxiayang
Copy link
Collaborator

Shall we add a build test to cover such case in the follow up PR?

Ideally, this should be caught by CI directly.

I agree.

@SageMoore
Copy link
Contributor Author

Shall we add a build test to cover such case in the follow up PR?

Ideally, this should be caught by CI directly.

Looks like the AMD job was not run on #13321 which is why the build error slipped through the cracks.

Unfortunately, the AMD job has been red for quite some time and we don't want to add additional noise to inflight PRs. We've made decent strides towards getting that build green, but there's more work to do. If you are interested in contributing to this effort, feel free to reach out to me on the vllm slack and I can provide some more context. There's nothing really hard here, we just need to grind through all of the failures.

@robertgshaw2-redhat robertgshaw2-redhat merged commit 45f3f3f into vllm-project:main Mar 12, 2025
69 checks passed
@SageMoore SageMoore deleted the sage/fix-amd-build branch March 12, 2025 14:14
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants