Skip to content

Conversation

dtrifiro
Copy link
Contributor

uv uses its own cache in /root/.cache/uv and does not use /root/.cache/pip

fixup to #13566

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 20, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was an oversight

@dtrifiro dtrifiro force-pushed the dockerfile-fix-uv-caching branch from 8218dca to 9e1c71e Compare February 20, 2025 15:36
@dtrifiro
Copy link
Contributor Author

Force pushed to add dco signoff, unsure why CI is failing though.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Feb 20, 2025

Something wrong with CI, unrelated to this change?

[2025-02-20T15:37:47Z] 🚨 Error: Error setting up job executor: The global environment hook exited with status 53

@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 22, 2025

Let me try rebuilding.

Update: The Docker container has been built successfully so I'm merging this now.

@simon-mo simon-mo merged commit 78ac0f5 into vllm-project:main Feb 22, 2025
15 of 18 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants