Skip to content

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 19, 2025

Improvement from 33min -> 28.5min

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 19, 2025
Signed-off-by: mgoin <[email protected]>
@khluu khluu enabled auto-merge (squash) February 20, 2025 00:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 20, 2025
@simon-mo simon-mo merged commit 497bc83 into vllm-project:main Feb 20, 2025
82 of 84 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@dtrifiro
Copy link
Contributor

@mgoin @khluu this broke caching, since uv uses its own cache in /root/.cache/uv and does not use /root/.cache/pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants