-
Notifications
You must be signed in to change notification settings - Fork 26
[CB] Update spyre model runner for new spyre input batch #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wallas Santos <[email protected]>
…s batching Signed-off-by: Wallas Santos <[email protected]>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
|
Currently, it pass in the tests of #79 |
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
…-refact-cb-1 Signed-off-by: Wallas Santos <[email protected]>
…-refact-cb-1 Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
…fact-cb-2 Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
…-refact-cb-2 Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
2bd358f to
1a143d1
Compare
Signed-off-by: Wallas Santos <[email protected]>
| self.execute_model(scheduler_output) | ||
|
|
||
| self.model_runner.tkv = 0 # type: ignore[union-attr] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannicks1, considering that the previous execute_model should correctly clean up the request of the model runner do we still need to reset the tkv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering that the previous execute_model should correctly clean up the request of the model runner
does it reset the tkv too? @wallashss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, no. I kept the reset by the worker. I should be fine.
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
…-refact-cb-2 Signed-off-by: Wallas Santos <[email protected]>
fix: tests for cb feat: assert to prevent activate cb with batch_size=1 Signed-off-by: Wallas Santos <[email protected]>
…re into wallas-refact-cb-2 Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Wallas Santos <[email protected]>
…re into wallas-refact-cb-2 Signed-off-by: Wallas Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
it seems like this is fixed, it wasn't working earlier with engine core's step function Signed-off-by: Prashant Gupta <[email protected]>
This PR primarily integrate the model runner with the new spyre input batch for continuous batching.
Summary:
For #76