refactor: remove no longer needed icon Safari workaround #9302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/remove-icon-workaround
branch
from
10ed9a7 to
3ead577
Compare
vursen
approved these changes
May 26, 2025
|
DiegoCardoso
added a commit
that referenced
this pull request
Oct 6, 2025
…)" This reverts commit f662fa4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
IconFontSizeMixinwas added for Safari 15-16:The WebKit issue was fixed and the fix was released in Safari 17.2:
In Vaadin 25 we are bumping Safari support to 17.x so it should be safe to remove this workaround.
Type of change