chore: more sophisticated checking for font icon sizing fallback #6440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the FF version on CI is old enough not to support CQ
tomivirkki
force-pushed
the
chore/icon/font-icon-fallback-check
branch
from
180eca3 to
a393b30
Compare
tomivirkki
force-pushed
the
chore/icon/font-icon-fallback-check
branch
from
4061d2d to
ec74d2c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
DiegoCardoso
approved these changes
Sep 1, 2023
|
This ticket/PR has been released with Vaadin 24.2.0.alpha10 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
<vaadin-icon>component uses a sizing-related fallback mechanism for font icons on browsers that don't support Container Query units for pseudo-elements.The fallback is currently only needed on the following supported browsers:
The need for the fallback is currently determined by testing support for Container Queries or simply checking if the Browser is Safari.
Since the Webkit bug has already been fixed and the fix will assumably start landing with Safari 16+ versions in the near future, it's better to detect whether Container Queries work correctly on the (Safari) browser instead of always using the fallback regardless of the Safari version.