Skip to content

Resolve build errors: update/remove kv cache APIs, disable building tools, latest release & upstream org ref #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025

Conversation

brittlewis12
Copy link
Contributor

@brittlewis12 brittlewis12 commented May 24, 2025

Hi Marcus, thanks for continuing to maintain this excellent project!

I encountered a few small issues catching up to the latest llama.cpp release:

I also noticed the repo has a stale organization reference for the git submodule -- not a big deal since github redirects it, but figured worth keeping up-to-date

let me know if you have any further feedback about these changes -- eg I could imagine wanting to rename the public-facing kv_cache_* methods to kv_self_* to mirror upstream? and whatever else comes to mind.

have a lovely weekend!

@MarcusDunn
Copy link
Contributor

MarcusDunn commented May 26, 2025

renaming the functions to match upstream would be appreciated, but I see no reason for that to block this PR.

Always appreciative of the PRs! Thanks!

@MarcusDunn MarcusDunn merged commit 0ae78da into utilityai:main May 26, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants