Resolve build errors: update/remove kv cache APIs, disable building tools, latest release & upstream org ref #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Marcus, thanks for continuing to maintain this excellent project!
I encountered a few small issues catching up to the latest llama.cpp release:
tools/
dir in llama.cpp for certain popularexamples/
-- disabled these in thebuild.rs
to align with avoiding building tests, examples, etc.cargo fmt
), so I also included the small change tobuild.rs
llama_kv_cache_*
APIs have been renamedllama_kv_self
as you noted in compile error forupdate-llama-cpp-2025-05-21
branch #739 (and the kv cache view APIs were removed entirely)I also noticed the repo has a stale organization reference for the git submodule -- not a big deal since github redirects it, but figured worth keeping up-to-date
let me know if you have any further feedback about these changes -- eg I could imagine wanting to rename the public-facing
kv_cache_*
methods tokv_self_*
to mirror upstream? and whatever else comes to mind.have a lovely weekend!