-
Notifications
You must be signed in to change notification settings - Fork 12k
llama : move end-user examples to tools directory #13249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we also need to add LLAMA_BUILD_TOOLS=NO for certain CI, dockerfiles and some build scripts for android/mac/ios Btw I think it's a good opportunity to change the name llava --> mtmd, I can do that in another PR |
Btw, I think this could be a breaking change since some people can have automate script to pull things from certain places of llama.cpp ; for example, downstream projects like LM Studio and ollama pulls the @ggerganov I think making a comm like the last time we move the project from |
@slaren the web ui may fails to build on windows (I suspect because the node does not use I'll push a build from macos rn, which should work |
I am on WSL, which is a Linux VM, so it should work. I was wondering if it is due to the node version? I have 19.9.0 from the ubuntu repository. |
I never tested with node v19, but yeah that could be the reason. A fix could be to use a gzip implementation in pure JS, which will be more deterministic. |
Moves examples that are intended to be used by end users (rather than developers) to a separate
tools
directory. Eventually only these programs will be included in the binary distributions.This is the tentative list of examples "promoted" to tools in this PR: