-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Block List: Fix inline mode #20745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block List: Fix inline mode #20745
Conversation
|
Hi there @andrejd22, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the block workspace view edit component to use container IDs instead of keys for tab identification. The changes simplify tab management by removing redundant state tracking and aligning with the proper data structure.
- Removes commented-out code and unused
_activeTabNamestate variable - Changes tab identification from using
tab.keytotab.ids[0] - Simplifies the
#setTabNamemethod to#setTabKeyby removing the unused tab name parameter - Improves code formatting and consistency
...ages/block/block/workspace/views/edit/block-workspace-view-edit-content-no-router.element.ts
Outdated
Show resolved
Hide resolved
...ages/block/block/workspace/views/edit/block-workspace-view-edit-content-no-router.element.ts
Outdated
Show resolved
Hide resolved
...ages/block/block/workspace/views/edit/block-workspace-view-edit-content-no-router.element.ts
Show resolved
Hide resolved
Commented out unused state properties and related code.
nielslyngsoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrejd22 Very good, and so well spotted.
I took the freedom to improve a little bit now that the PR came around here.
I will as well investigate if we can backport this.
Thanks for the insight and work, this surely helped getting this issue resolve faster!
* Fix block list inline mode #20618 * Fixed potential runtime errors * Code cleanup * Fixed Code Health Review * Revert some changes Commented out unused state properties and related code. * Remove commented-out state property in block workspace view * fix localization * no need for question mark after ids, they should be presented as required --------- Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
|
This pull request has been mentioned on Umbraco community forum. There might be relevant details there: https://forum.umbraco.com/t/minor-update-makes-content-not-accessible/6715/2 |
Fix for #20618
Prerequisites
If there's an existing issue for this PR then this fixes
Description