Skip to content

Conversation

@andrejd22
Copy link
Contributor

Fix for #20618

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Copilot AI review requested due to automatic review settings November 5, 2025 15:21
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi there @andrejd22, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the block workspace view edit component to use container IDs instead of keys for tab identification. The changes simplify tab management by removing redundant state tracking and aligning with the proper data structure.

  • Removes commented-out code and unused _activeTabName state variable
  • Changes tab identification from using tab.key to tab.ids[0]
  • Simplifies the #setTabName method to #setTabKey by removing the unused tab name parameter
  • Improves code formatting and consistency

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 10, 2025 15:46
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrejd22 Very good, and so well spotted.

I took the freedom to improve a little bit now that the PR came around here.
I will as well investigate if we can backport this.

Thanks for the insight and work, this surely helped getting this issue resolve faster!

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 10, 2025 15:51
@nielslyngsoe nielslyngsoe merged commit 9fa382e into umbraco:main Nov 10, 2025
28 checks passed
nielslyngsoe added a commit that referenced this pull request Nov 10, 2025
nielslyngsoe added a commit that referenced this pull request Nov 10, 2025
* Fix block list inline mode

#20618

* Fixed potential runtime errors

* Code cleanup

* Fixed Code Health Review

* Revert some changes

Commented out unused state properties and related code.

* Remove commented-out state property in block workspace view

* fix localization

* no need for question mark after ids, they should be presented as required

---------

Co-authored-by: Niels Lyngsø <[email protected]>
Co-authored-by: Niels Lyngsø <[email protected]>
@nielslyngsoe nielslyngsoe added release/17.0.0 release/16.4.0 status/regression A previously working feature that has broken or changed behavior unexpectedly labels Nov 10, 2025
@iOvergaard iOvergaard changed the title Fix block list inline mode Block List: Fix inline mode Nov 17, 2025
@umbracocommunity
Copy link

This pull request has been mentioned on Umbraco community forum. There might be relevant details there:

https://forum.umbraco.com/t/minor-update-makes-content-not-accessible/6715/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants