Block list: blocks with tabs not working in inline editing mode

[Luuk1983]

Which Umbraco version are you using?

16.3.2, 17.0.0-beta

Bug summary

When you have a block list set to use 'inline editing mode', any block that has tabs will not work. It will show the tabs, but not the content of the tabs:

Specifics

Steps to reproduce

1. Create an element type with tabs and add one or more properties to the tabs:

2. Add a new block list data type, add the block created in step 1 and set it for inline editing mode:

3. Create a document type that uses that block list and set it to 'allow at root', so we insert it:

4. When you add the block, it will show the tabs - and you can switch between the tabs - but the content of the tab will not be displayed:

Expected result / actual result

Obviously I expect the content of the tabs to show so that I'm able to edit the fields the are on the tabs.

---

This item has been added to our backlog AB#61219

[github-actions]

Hi there @Luuk1983!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[andrejd22]

@nielslyngsoe This issue is quite painful for us at the moment. I did some investigation and found that, in this case, the hasProperties value is always false:

I also looked into the UmbContentTypeContainerStructureHelper, and it seems that something might have been broken by the changes introduced in this improvement #19970

When can we expect the fixes to be released? We’ve already deployed version 16.3.4.

[andrejd22]

@nielslyngsoe @AndyButland I’ve created a PR #20745 with the fix — please review it. Can this be included in the 16.3.5 release?

[nielslyngsoe]

Hi @andrejd22

I have a developer looking into this next week. With the assumption that it is reliasticly to fix, which I certainly think, then that means it would be fixed in v.17.1. Which is the next planned fix.

Notice upgrading to v.17 is a soft major, very little breaking changes, so I hope you see your self getting on that version.

Let me know wehat you think

[andrejd22]

@nielslyngsoe After a detailed investigation, I identified the root cause and have already implemented the fix in the PR. I also made the fixes based on your comments.