Skip to content

Dictionary: Fix shortcut Ctrl + S not saving dictionary items #20605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 2 commits into from
Oct 22, 2025
Merged

Dictionary: Fix shortcut Ctrl + S not saving dictionary items #20605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8198d1
switched event listener from 'change' to 'input'
madsrasmussen Oct 22, 2025
c522de9
Update workspace-view-dictionary-editor.element.ts
madsrasmussen Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...lient/src/packages/dictionary/workspace/views/workspace-view-dictionary-editor.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { UMB_DICTIONARY_WORKSPACE_CONTEXT } from '../dictionary-workspace.context-token.js';
import type { UmbDictionaryDetailModel } from '../../types.js';
import type { UUITextareaElement } from '@umbraco-cms/backoffice/external/uui';
import { UUITextareaEvent } from '@umbraco-cms/backoffice/external/uui';
import { css, html, customElement, state, repeat } from '@umbraco-cms/backoffice/external/lit';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbLanguageCollectionRepository, type UmbLanguageDetailModel } from '@umbraco-cms/backoffice/language';
Expand Down Expand Up @@ -72,13 +71,11 @@ export class UmbWorkspaceViewDictionaryEditorElement extends UmbLitElement {
}

#onTextareaChange(e: Event) {
if (e instanceof UUITextareaEvent) {
const target = e.composedPath()[0] as UUITextareaElement;
const translation = (target.value as string).toString();
const isoCode = target.getAttribute('name')!;
const target = e.composedPath()[0] as UUITextareaElement;
const translation = (target.value as string).toString();
const isoCode = target.getAttribute('name')!;

this.#workspaceContext?.setPropertyValue(isoCode, translation);
}
this.#workspaceContext?.setPropertyValue(isoCode, translation);
}

override render() {
Expand All @@ -104,7 +101,7 @@ export class UmbWorkspaceViewDictionaryEditorElement extends UmbLitElement {
slot="editor"
name=${language.unique}
label="translation"
@change=${this.#onTextareaChange}
@input=${this.#onTextareaChange}
.value=${translation?.translation ?? ''}
?readonly=${this.#isReadOnly(language.unique)}></uui-textarea>
</umb-property-layout>`;
Expand Down
Loading