Dictionary: Fix shortcut Ctrl + S not saving dictionary items #20605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the Ctrl + S keyboard shortcut was not saving dictionary items because changes were not being detected. The fix changes the event listener from @change to @input to capture text input immediately rather than waiting for the textarea to lose focus.
Key Changes
- Changed event listener from
@changeto@inputon the textarea element - Removed unnecessary type guard checking for
UUITextareaEvent
madsrasmussen
changed the title
nielslyngsoe
added a commit
that referenced
this pull request
Oct 22, 2025
* switched event listener from 'change' to 'input' * Update workspace-view-dictionary-editor.element.ts
nielslyngsoe
added
release/16.4.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20527
Change the event listener from
changetoinputto ensure changes are detected when using the Ctrl + S keyboard shortcut.