Log Viewer: Fixes continuous polling (closes #20274) #20310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where the log viewer continues polling the server for new logs even after the user navigates away from the log viewer workspace, causing unnecessary network requests.
- Adds proper cleanup of polling interval when the workspace is disconnected
- Extracts interval clearing logic into a reusable
stopPolling()method - Ensures polling stops when user leaves the log viewer workspace
src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts
Show resolved
Hide resolved
…gviewer-workspace.context.ts Co-authored-by: Copilot <[email protected]>
AndyButland
approved these changes
Sep 30, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Works nicely, thanks @leekelleher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20274.
Stops the log viewer from polling the server when the user has navigated away from the log viewer workspace.
How to test?
Go to the Log Viewer workspace (Search view), start the polling. Notice in the browser dev-tools (Network tab) that the requests are being made at the set interval. Navigate away from the Log Viewer workspace. Notice that the server requests have now stopped.