Skip to content

Log Viewer: Fixes continuous polling (closes #20274) #20310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 2 commits into from
Sep 30, 2025
Merged

Log Viewer: Fixes continuous polling (closes #20274) #20310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8d8312
LogViewer: Fixes continuous polling (closes #20274)
leekelleher Sep 29, 2025
56ee4bd
Update src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/lo…
leekelleher Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW
override hostDisconnected(): void {
super.hostDisconnected();
window.removeEventListener('changestate', this.onChangeState);
this.stopPolling();
}

onChangeState = () => {
Expand Down Expand Up @@ -320,7 +321,7 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW
return;
}

clearInterval(this.#intervalID as number);
this.stopPolling();
}

setPollingInterval(interval: UmbPoolingInterval) {
Expand All @@ -332,6 +333,13 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW
const newDirection = direction === DirectionModel.ASCENDING ? DirectionModel.DESCENDING : DirectionModel.ASCENDING;
this.#sortingDirection.setValue(newDirection);
}

stopPolling() {
if (this.#intervalID) {
clearInterval(this.#intervalID);
this.#intervalID = null;
}
}
}

export { UmbLogViewerWorkspaceContext as api };
Loading