Add defensive coding to the member application initializer (16) #19764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds defensive coding to prevent race conditions and duplicate initialization in the member application initializer during Umbraco startup. The changes ensure thread-safe initialization and prevent subscriber server roles from modifying member applications.
- Adds thread synchronization using SemaphoreSlim to prevent concurrent initialization
- Implements server role checking to skip initialization on subscriber instances
- Introduces initialization state tracking to prevent duplicate operations
src/Umbraco.Cms.Api.Delivery/Handlers/InitializeMemberApplicationNotificationHandler.cs
Outdated
Show resolved
Hide resolved
kjac
deleted the
v16/improvement/defensive-updates-for-member-application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19760 cherry-picked for 16 with conflicts resolved.