Add defensive coding to the member application initializer #19760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: This needs to be cherry-picked to V16 👍 |
AndyButland
approved these changes
Jul 21, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Code looks good to me to ensure that this can only run once, and stepping through/examining the database records indicates it functions as before.
AndyButland
deleted the
v13/improvement/defensive-updates-for-member-application
branch
AndyButland
added a commit
that referenced
this pull request
Jul 21, 2025
kjac
added a commit
that referenced
this pull request
Jul 21, 2025
* Add defensive coding to the member application initializer (#19760) * Moved _isInitialized to after the initialization --------- Co-authored-by: kjac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #18588
Description
The linked issue describes a concurrency issue during boot time.
This is ultimately triggered by
UmbracoApplicationStartingNotificationsomehow being fired twice, which should not be possible but clearly it happens.I have not been able to reproduce it, so this PR adds defensive coding around the notification handler to guard against concurrent updates.
Testing this PR
umbracoOpenIddictApplicationstable is updated accordingly at boot time.