-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V16: Retry requests after timeout #19495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this could potentially try to re-register all private extensions after each auth signal, which is being prevented anyway because of duplicate aliases, but still nice to remove and not have to listen to
…ternal load before registering core extensions
…rs say so as well
… you more easily can opt out of it and everything is gathered in one place
…andled by tryExecute
…laceholders) to tell the user what did not succeed
… from the outside
This was referenced Jul 28, 2025
This was referenced Aug 26, 2025
This was referenced Sep 8, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements and fixes across multiple files, focusing on debugging improvements, dependency updates, and authorization handling. The changes aim to streamline workflows, improve user experience during authentication, and ensure compatibility with updated dependencies.
How to test / Video
2025-06-06.at.14.25.00.-.Emerald.Quail.mp4
(Note: The last example in the video where I had to click twice to show the screen has been fixed by replacing
throttleTimewithauditTimeto wait a bit before firing the timeout signal)Changes
Debugging Enhancements:
.vscode/launch.json: Added apostDebugTaskto terminate theUmbraco.Web.UIprocess automatically after debugging sessions. [1] [2].vscode/tasks.json: Introduced a new task,kill-umbraco-web-ui, to terminate theUmbraco.Web.UIprocess across different operating systems.Dependency Updates:
src/Umbraco.Web.UI.Client/src/packages/core/package.json: Updated versions of@hey-api/client-fetchand@hey-api/openapi-tsdependencies.Authorization Handling Improvements:
src/Umbraco.Web.UI.Client/src/apps/backoffice/backoffice.element.ts: Refactored the authorization flow to ensure private extensions are registered only after successful authorization. (Mentioned in v15/v16: Race conditions after UMB_AUTH_CONTEXT -> isAuthorized and private manifests #19485 but does not fully fix that issue)src/Umbraco.Web.UI.Client/src/packages/core/auth/auth.context.ts: Improved observables for authorization and timeout signals by adding throttling and distinct change detection. [1] [2] [3]API Enhancements:
src/Umbraco.Web.UI.Client/src/packages/core/resources/api-interceptor.controller.ts: Enhanced interceptors for handling 401 and 403 responses, including retry logic for GET requests and better error notifications for non-idempotent requests. Introduced mechanisms to queue and retry unauthorized requests after re-authentication. [1] [2] [3]UmbProblemDetailsshape. This allows the client to show more comprehensive error messages rather than just the default "An error occurred".tryExecuteto expect that it is an api error happening.These changes collectively enhance the development workflow, improve debugging and authorization handling, and ensure compatibility with updated dependencies.