-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V16: Retry requests after timeout #19495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
472f530
feat: fix a small-ish nitpick where extensions would reload after login
iOvergaard 147bf98
feat: align login UI extension load with backoffice, i.e. wait for ex…
iOvergaard e053af1
build(deps): bump @hey-api to newest and re-generate client
iOvergaard 4f660a6
chore: adds extra error logging
iOvergaard 57a57a4
feat: adds retry logic to the api interceptor
iOvergaard 6292ffa
feat: warn about incomplete actions
iOvergaard 2101bf5
fix: the body was already plain text, but we need to ensure the heade…
iOvergaard a23be07
feat: warns the user when actions could not be completed
iOvergaard 26edd73
build(deps): update @hey-api/client-fetch
iOvergaard 1030ff8
chore: generate new api
iOvergaard 94da54c
feat: simplify error handling to just UmbApiError and UmbCancelError
iOvergaard a8f9e51
feat: moves error notifications from interceptors into tryExecute, so…
iOvergaard 6e254c4
Merge branch 'main' into v16/feature/retry-requests
iOvergaard 0bbd074
feat: recreate responses with correct 'status' and 'statusText'
iOvergaard 0e6a885
build: stop dotnet processes after debug session
iOvergaard 32d1a46
feat: extrapolate common logic into helper method to create responses
iOvergaard 14f3176
feat: returns a UmbProblemDetails like object on interceptors to be h…
iOvergaard e943a3c
chore: deprecates duplicate, outdated UmbProblemDetails interface and…
iOvergaard f3a90c8
feat: uses the 'title' of the problem details object to convey the ma…
iOvergaard 9d133bd
chore: 401 and 403 uses their own interceptors
iOvergaard 8eae4c3
feat: show no notification if 401
iOvergaard 48306f6
feat: uses the real request method and url (instead of the template p…
iOvergaard a03fa89
feat: retry requests with no timeout/race
iOvergaard 7a74f6d
feat: throttle and delay signals and disallow them from being updated…
iOvergaard d014145
chore: adds more logging to timeouts
iOvergaard a629fe7
Merge branch 'main' into v16/feature/retry-requests
iOvergaard 45b5d29
chore: optimise imports
iOvergaard 75c8b42
test: ignores any test files left in node_modules folder
iOvergaard ddae4ff
Merge branch 'main' into v16/feature/retry-requests
iOvergaard b858cb3
feat: uses auditTime to wait a bit before showing the timeout screen
iOvergaard 1852177
Merge branch 'main' into v16/feature/retry-requests
iOvergaard ea273fa
Merge branch 'main' into v16/feature/retry-requests
iOvergaard fd9574f
feat: adds 404 handling to error interceptor
iOvergaard 0f91dc3
chore: cleans up after response modification
iOvergaard 314d6b1
feat: preserve only a few headers
iOvergaard 1064cbd
feat: lets the UI handle 404 errors instead of notifying directly
iOvergaard e59743f
test: uses create action menu option instead to find the correct loca…
iOvergaard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,76 +1,87 @@ | ||
| { | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "label": "Build", | ||
| "detail": "Builds the client and SLN", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "dependsOn": [ | ||
| "Client Build", | ||
| "Dotnet build" | ||
| ], | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Install", | ||
| "detail": "install npm for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "type": "npm", | ||
| "script": "install", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Build", | ||
| "detail": "runs npm run build for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "type": "npm", | ||
| "script": "build:for:cms", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Watch", | ||
| "detail": "runs npm run dev for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "type": "npm", | ||
| "script": "dev", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Dotnet build", | ||
| "detail": "Dotnet build of SLN", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "command": "dotnet", | ||
| "type": "process", | ||
| "args": [ | ||
| "build", | ||
| "${workspaceFolder}/umbraco.sln", | ||
| "/property:GenerateFullPaths=true", | ||
| "/consoleloggerparameters:NoSummary" | ||
| ], | ||
| "problemMatcher": "$msCompile" | ||
| }, | ||
| { | ||
| "label": "Dotnet watch", | ||
| "detail": "Dotnet run and watch of Web.UI", | ||
| "promptOnClose": true, | ||
| "command": "dotnet", | ||
| "type": "process", | ||
| "args": [ | ||
| "watch", | ||
| "run", | ||
| "--project", | ||
| "${workspaceFolder}/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj", | ||
| "/property:GenerateFullPaths=true", | ||
| "/consoleloggerparameters:NoSummary" | ||
| ], | ||
| "problemMatcher": "$msCompile" | ||
| } | ||
| ] | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "label": "Build", | ||
| "detail": "Builds the client and SLN", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "dependsOn": ["Client Build", "Dotnet build"], | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Install", | ||
| "detail": "install npm for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "type": "npm", | ||
| "script": "install", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Build", | ||
| "detail": "runs npm run build for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "type": "npm", | ||
| "script": "build:for:cms", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Client Watch", | ||
| "detail": "runs npm run dev for Umbraco.Web.UI.Client", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "type": "npm", | ||
| "script": "dev", | ||
| "path": "src/Umbraco.Web.UI.Client/", | ||
| "problemMatcher": [] | ||
| }, | ||
| { | ||
| "label": "Dotnet build", | ||
| "detail": "Dotnet build of SLN", | ||
| "promptOnClose": true, | ||
| "group": "build", | ||
| "command": "dotnet", | ||
| "type": "process", | ||
| "args": [ | ||
| "build", | ||
| "${workspaceFolder}/umbraco.sln", | ||
| "/property:GenerateFullPaths=true", | ||
| "/consoleloggerparameters:NoSummary" | ||
| ], | ||
| "problemMatcher": "$msCompile" | ||
| }, | ||
| { | ||
| "label": "Dotnet watch", | ||
| "detail": "Dotnet run and watch of Web.UI", | ||
| "promptOnClose": true, | ||
| "command": "dotnet", | ||
| "type": "process", | ||
| "args": [ | ||
| "watch", | ||
| "run", | ||
| "--project", | ||
| "${workspaceFolder}/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj", | ||
| "/property:GenerateFullPaths=true", | ||
| "/consoleloggerparameters:NoSummary" | ||
| ], | ||
| "problemMatcher": "$msCompile" | ||
| }, | ||
| { | ||
| "label": "kill-umbraco-web-ui", | ||
| "type": "shell", | ||
| "problemMatcher": [], | ||
| "osx": { | ||
| "command": "pkill -f Umbraco.Web.UI" | ||
| }, | ||
| "linux": { | ||
| "command": "pkill -f Umbraco.Web.UI" | ||
| }, | ||
| "windows": { | ||
| "command": "taskkill /IM Umbraco.Web.UI.exe /F" | ||
| } | ||
| } | ||
| ] | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,4 +21,7 @@ export { | |
| switchMap, | ||
| takeUntil, | ||
| tap, | ||
| delay, | ||
| throttleTime, | ||
| auditTime, | ||
| } from 'rxjs'; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.