Skip to content

fix: Missing domain in error messages #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2020
Merged

fix: Missing domain in error messages #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reporting/reportConversionResults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe("reportConversionResults", () => {
logger.stdout.write,
`☠ Prettier plugins are missing from your configuration. ☠`,
` We highly recommend running tslint-to-eslint-config --prettier to disable formatting ESLint rules.`,
` See https://github/typescript-eslint/tslint-to-eslint-config/docs/FAQs.md#should-i-use-prettier.`,
` See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.`,
);
});

Expand All @@ -262,7 +262,7 @@ describe("reportConversionResults", () => {
logger.stdout.write,
`☠ Prettier plugins are missing from your configuration. ☠`,
` We highly recommend running tslint-to-eslint-config --prettier to disable formatting ESLint rules.`,
` See https://github/typescript-eslint/tslint-to-eslint-config/docs/FAQs.md#should-i-use-prettier.`,
` See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.`,
);
});
});
2 changes: 1 addition & 1 deletion src/reporting/reportConversionResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const logPrettierExtension = (logger: Logger) => {
logger.stdout.write(chalk.red(` to disable formatting ESLint rules.${EOL}`));
logger.stdout.write(
chalk.red(
` See https://github/typescript-eslint/tslint-to-eslint-config/docs/FAQs.md#should-i-use-prettier.${EOL}`,
` See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.${EOL}`,
),
);
};