Skip to content

fix: Missing domain in error messages #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

fix: Missing domain in error messages #441

merged 1 commit into from
May 3, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented May 3, 2020

PR Checklist

Overview

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my. Thank you!

@nschonni
Copy link
Contributor Author

nschonni commented May 3, 2020

Think it may need "tree/master" as well, just double checking

@nschonni
fix: Missing domain in error messages
ca89d00 
Add blob/master/ for direct access to file
@nschonni nschonni force-pushed the missing-domains branch from 1865116 to ca89d00 Compare May 3, 2020 04:04
@nschonni
Copy link
Contributor Author

nschonni commented May 3, 2020

Confirmed that there was another piece needed blob/master/, and rebased to add it

@JoshuaKGoldberg JoshuaKGoldberg merged commit 575b619 into typescript-eslint:master May 3, 2020
@nschonni nschonni deleted the missing-domains branch May 3, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nschonni @JoshuaKGoldberg