-
-
Notifications
You must be signed in to change notification settings - Fork 505
Update django to 5.0.5 #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update django to 5.0.5 #2131
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
53d34ad
Update django to 5.0.5
sobolevn 7652d75
Fix CI
sobolevn 1b4754e
Update django to 4.2.12
sobolevn 69d1d1c
Fix CI
sobolevn fe19e0e
Fix CI
sobolevn 5c39250
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 27def9f
Fix CI
sobolevn e97f748
Merge branch 'django-5.0.5' of https://github.com/typeddjango/django-…
sobolevn 8157dcd
Try `ignore_errors`
sobolevn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,14 @@ | ||
from typing import Any | ||
|
||
from django.contrib.gis.db.backends.base.features import BaseSpatialFeatures | ||
from django.db.backends.oracle.features import DatabaseFeatures as OracleDatabaseFeatures | ||
from django.utils.functional import cached_property | ||
|
||
class DatabaseFeatures(BaseSpatialFeatures, OracleDatabaseFeatures): | ||
supports_add_srs_entry: bool | ||
supports_geometry_field_introspection: bool | ||
supports_geometry_field_unique_index: bool | ||
supports_perimeter_geodetic: bool | ||
supports_dwithin_distance_expr: bool | ||
@cached_property | ||
def django_test_skips(self) -> dict[str, Any]: ... # type: ignore[override] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have to figure out a way to work with
cached_property
without this hackThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Django was planning to replace their homegrown
cached_property
implementation withfunctools.cached_property
in 5.1 or 5.2.If we have the patience to wait until then, this will resolve itself 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might take quite some time? According to this comment and ticket https://code.djangoproject.com/ticket/30949#comment:14
Or is it mentioned to be replaced someplace else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think you're right, it will take years.