Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 7, 2024

Closes #2130

@intgr intgr added the release notes reminder User impact should be explicitly documented in release notes. label May 7, 2024
@intgr
Copy link
Collaborator

intgr commented May 7, 2024

The new djang-stubs[oracle] extra should be mentioned in release notes.

django.urls.resolvers.URLResolver.url_patterns
django.urls.resolvers.URLResolver.urlconf_module
django.utils.connection.BaseConnectionHandler.settings
django.db.models.Q.referenced_base_fields
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have to figure out a way to work with cached_property without this hack

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Django was planning to replace their homegrown cached_property implementation with functools.cached_property in 5.1 or 5.2.

If we have the patience to wait until then, this will resolve itself 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might take quite some time? According to this comment and ticket https://code.djangoproject.com/ticket/30949#comment:14

Or is it mentioned to be replaced someplace else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think you're right, it will take years.

@sobolevn sobolevn merged commit b1508f2 into master May 7, 2024
@sobolevn sobolevn deleted the django-5.0.5 branch May 7, 2024 10:37
@flaeppe flaeppe removed the release notes reminder User impact should be explicitly documented in release notes. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants