Skip to content

PM-2439 Fix year selection in form #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

PM-2439 Fix year selection in form #1270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbdd191
PM-2439 Fix year selection in form
himaniraghav3 Oct 22, 2025
69a7641
Remove typo
himaniraghav3 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions ...member-profile/education-and-certifications/ModifyEducationModal/ModifyEducationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ const ModifyEducationModal: FC<ModifyEducationModalProps> = (props: ModifyEducat
= useState<boolean>(props.education?.length === 0 || false)

const [formValues, setFormValues]: [
{ [key: string]: string | boolean | Date | undefined },
Dispatch<SetStateAction<{ [key: string]: string | boolean | Date | undefined }>>
{ [key: string]: string | boolean | Date | number | undefined },
Dispatch<SetStateAction<{ [key: string]: string | boolean | Date | number | undefined }>>
]
= useState<{ [key: string]: string | boolean | Date | undefined }>({})
= useState<{ [key: string]: string | boolean | Date | number | undefined }>({})

const [formErrors, setFormErrors]: [
{ [key: string]: string },
Expand Down Expand Up @@ -91,9 +91,14 @@ const ModifyEducationModal: FC<ModifyEducationModalProps> = (props: ModifyEducat
}

function handleFormValueChange(key: string, event: React.ChangeEvent<HTMLInputElement>): void {

const value = key === 'endYear'
Copy link

@github-actions github-actions bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Consider adding validation to ensure event.target.value can be safely converted to a number before using Number(). This will prevent potential issues if the input is not a valid number.

? Number(event.target.value)
: event.target.value

setFormValues({
...formValues,
[key]: event.target.value,
[key]: value,
})
}

Expand Down Expand Up @@ -266,11 +271,11 @@ const ModifyEducationModal: FC<ModifyEducationModalProps> = (props: ModifyEducat
/>
<InputSelect
options={yearOptions}
value={`${getYear(formValues.endDate as Date)}`}
onChange={bind(handleFormValueChange, this, 'endDate')}
value={`${Number(formValues.endYear)}`}
onChange={bind(handleFormValueChange, this, 'endYear')}
dirty
error={formErrors.endDate}
name='endDate'
error={formErrors.endYear}
name='endYear'
label='End Year or Expected'
placeholder='Select a year'
tabIndex={0}
Expand Down