PM-2439 Fix year selection in form #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| function handleFormValueChange(key: string, event: React.ChangeEvent<HTMLInputElement>): void { | ||
|
|
||
| const value = key === 'endYear' |
There was a problem hiding this comment.
[correctness]
Consider adding validation to ensure event.target.value can be safely converted to a number before using Number(). This will prevent potential issues if the input is not a valid number.
| label='End Year or Expected' | ||
| error={formErrors.endYear} | ||
| name='endYear' | ||
| label='End Year or Expected hhhh' |
There was a problem hiding this comment.
[💡 readability]
The label 'End Year or Expected hhhh' seems to contain a typo or placeholder text ('hhhh'). Ensure this is intentional or update it to the correct label.
jmgasper
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-2439
What's in this PR?
API expects number as end of year