Skip to content

Use private for private members in classes instead of # #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Feb 29, 2024

PR-Codex overview

This PR updates code across multiple packages to replace # with private for private members in classes.

Detailed summary

  • Replaced # with private for private members in classes across various files
  • Updated classes: EngineWallet, GcpKmsWallet, CoinbasePayIntegration, SignerWallet, FrameConnector, InjectedConnector, EthersWallet, Cache, AsyncWallet, PrivateKeyWallet, TransactionError, BasicLogger, PhantomConnector, RainbowConnector, MetaMaskConnector, AwsKmsWallet

The following files were skipped due to too many changes: packages/wallets/src/evm/wallets/aws-kms.ts, packages/wallets/src/evm/connectors/paper/index.ts, packages/wallets/src/evm/connectors/magic/index.ts, packages/wallets/src/evm/connectors/local-wallet/index.ts, packages/wallets/src/evm/connectors/signer/index.ts, packages/wallets/src/evm/wallets/local-wallet.ts, packages/wallets/src/evm/connectors/embedded-wallet/index.ts, packages/wallets/src/evm/wallets/base.ts, packages/wallets/src/evm/wallets/aws-secrets-manager.ts, packages/wallets/src/evm/connectors/coinbase-wallet/index.ts, packages/wallets/src/evm/connectors/blocto/index.ts, packages/wallets/src/evm/wallets/wallet-connect.ts, packages/wallets/src/core/WalletConnect/WalletConnectV2Handler.ts, packages/wallets/src/evm/connectors/wallet-connect/index.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@MananTank MananTank requested a review from a team as a code owner February 29, 2024 15:01
@MananTank MananTank requested a review from a team February 29, 2024 15:01
Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: d0fb336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/crypto Patch
thirdweb Patch
@thirdweb-dev/pay Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/merkletree Patch
@thirdweb-dev/storage Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MananTank MananTank changed the title Use private foo instead of #foo in classes Use private for private members in classes instead of # Feb 29, 2024
@MananTank
Copy link
Member Author

/release-pr

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.95%. Comparing base (cc22fa8) to head (d0fb336).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/sdk/src/evm/common/error.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   66.92%   66.95%   +0.02%     
==========================================
  Files         293      293              
  Lines       11250    11250              
  Branches     1564     1564              
==========================================
+ Hits         7529     7532       +3     
+ Misses       3085     3082       -3     
  Partials      636      636              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MananTank MananTank added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit bc198e2 Feb 29, 2024
@MananTank MananTank deleted the mnn/no-hash-private branch February 29, 2024 17:54
@jnsdls jnsdls mentioned this pull request Feb 29, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant