Use private for private members in classes instead of # (#2374)

Author: MananTank

.changeset/tiny-forks-help.md

@@ -0,0 +1,9 @@
+---
+"@thirdweb-dev/wallets": patch
+"@thirdweb-dev/crypto": patch
+"thirdweb": patch
+"@thirdweb-dev/pay": patch
+"@thirdweb-dev/sdk": patch
+---
+
+Use `private foo` instead of `#foo` for making the members private in classes

packages/cli/src/core/helpers/logger.ts

@@ -12,39 +12,39 @@ function shouldLog(minLevel: LogLevel, currentLevel: LogLevel): boolean {
 }
 
 class BasicLogger {
-  #minLevel: LogLevel = "info";
+  private _minLevel: LogLevel = "info";
   constructor(params?: BasicLoggerConstructorParams) {
     if (params?.minLevel) {
-      this.#minLevel = params.minLevel;
+      this._minLevel = params.minLevel;
     }
   }
 
   setSettings(params: BasicLoggerConstructorParams) {
     if (params.minLevel) {
-      this.#minLevel = params.minLevel;
+      this._minLevel = params.minLevel;
     }
   }
 
   debug(...args: any[]) {
-    if (shouldLog(this.#minLevel, "debug")) {
+    if (shouldLog(this._minLevel, "debug")) {
       console.info(...args);
     }
   }
 
   info(...args: any[]) {
-    if (shouldLog(this.#minLevel, "info")) {
+    if (shouldLog(this._minLevel, "info")) {
       console.info(...args);
     }
   }
 
   warn(...args: any[]) {
-    if (shouldLog(this.#minLevel, "warn")) {
+    if (shouldLog(this._minLevel, "warn")) {
       console.warn(...args);
     }
   }
 
   error(...args: any[]) {
-    if (shouldLog(this.#minLevel, "error")) {
+    if (shouldLog(this._minLevel, "error")) {
       console.error(...args);
     }
   }

packages/crypto/src/utils/cache.ts

@@ -1,19 +1,19 @@
 class TextProcessorCache {
-  #encoder: TextEncoder | undefined;
-  #decoder: TextDecoder | undefined;
+  private _encoder: TextEncoder | undefined;
+  private _decoder: TextDecoder | undefined;
 
   get encoder(): TextEncoder {
-    if (!this.#encoder) {
-      this.#encoder = new TextEncoder();
+    if (!this._encoder) {
+      this._encoder = new TextEncoder();
     }
-    return this.#encoder;
+    return this._encoder;
   }
 
   get decoder(): TextDecoder {
-    if (!this.#decoder) {
-      this.#decoder = new TextDecoder();
+    if (!this._decoder) {
+      this._decoder = new TextDecoder();
     }
-    return this.#decoder;
+    return this._decoder;
   }
 }
 

packages/pay/src/integrations/coinbase/index.ts

@@ -16,9 +16,9 @@ export type FundWalletOptions = {
 };
 
 export class CoinbasePayIntegration {
-  #appId: string;
+  private _appId: string;
   constructor(options: CoinbasePayOptions) {
-    this.#appId = options.appId;
+    this._appId = options.appId;
   }
 
   async fundWallet(opts: FundWalletOptions): Promise<void> {
@@ -27,7 +27,7 @@ export class CoinbasePayIntegration {
     return new Promise((res, rej) => {
       initOnRamp(
         {
-          appId: this.#appId,
+          appId: this._appId,
           widgetParameters: {
             destinationWallets: [
               {

packages/sdk/src/evm/common/error.ts

@@ -284,9 +284,9 @@ export type TransactionErrorInfo = {
  * @public
  */
 export class TransactionError extends Error {
-  #reason: string;
-  #info: TransactionErrorInfo;
-  #raw: any;
+  private _reason: string;
+  private _info: TransactionErrorInfo;
+  private _raw: any;
 
   constructor(info: TransactionErrorInfo, raw: any) {
     let errorMessage = `\n\n\n╔═══════════════════╗\n║ TRANSACTION ERROR ║\n╚═══════════════════╝\n\n`;
@@ -363,22 +363,22 @@ export class TransactionError extends Error {
 
     super(errorMessage);
 
-    this.#reason = info.reason;
-    this.#info = info;
-    this.#raw = raw;
+    this._reason = info.reason;
+    this._info = info;
+    this._raw = raw;
   }
 
   // Keep reason here for backwards compatibility
   get reason(): string {
-    return this.#reason;
+    return this._reason;
   }
 
   get raw(): any {
-    return this.#raw;
+    return this._raw;
   }
 
   get info(): TransactionErrorInfo {
-    return this.#info;
+    return this._info;
   }
 }