Macro audit june 2022 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etRevealURI method
…eb-dev/contracts into signaturedrop-audit-macro
replace requires with custom errors
* [H-1] Wrapped ETH cannot be unwrapped * [L-1] Anyone can call renounceRole(), and delete the first valid entry from roleMembers for any role * [L-2] Incorrect supportsInterface implementation * [G-4] Require revert msg string length > 32 for Multiwrap: L176 (edited) * [G-3] Optimization done in CurrencyTransferLib for rare edge cases, increases gas costs for all other use cases. * [G-2] Improvements for _setBundle() * [L-7] Unsafe usage of msg.value within CurrencyTransfer library * [G-5] Return early in PermissionsEnumerable#getRoleMember Co-authored-by: Krishang Nadgauda <[email protected]>
* (Q-1) Unused variable * fix claim quantity limit fix claim quantity limit * cleanup * remove thirdwebfee remove thirdwebfee Co-authored-by: Krishang Nadgauda <[email protected]> Co-authored-by: yash <[email protected]> Co-authored-by: Krishang Nadgauda <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -75,8 +75,22 @@ | |||
| address _to, | |||
| Token[] memory _tokens | |||
| ) internal { | |||
| uint256 nativeTokenValue; | |||
Check warning
Code scanning / Slither
Uninitialized local variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR concludes the audit by 0xMacro for
Multiwrap,DropERC1155andSignatureDrop.