0xMacro audit Jun '22: DropERC1155 #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix claim quantity limit
remove thirdwebfee
added 2 commits
June 26, 2022 11:04
nkrishang
changed the title
nkrishang
added a commit
that referenced
this pull request
Jun 29, 2022
* [H-2] Batch reveal is permanently corrupted by invocation of public getRevealURI method * [L-3] LazyMint of a new batch can affect previous batch * [L-4] Incorrect handling of invalid role approvals/removals in Permissions.sol * [L-5] Incorrect processing of role approval in PermissionsEnumerable.sol * [L-6] claimCondition.startTimestamp is not enforced * docs update * reduce size by merging checks * update tests * [Q-1] Emitted TokensLazyMinted event does not match spec * [L-3] test fix * [Q-3] Some events could use indexed attributes * [Q-5] Visibility for following methods can be changed from public to external * [Q-4] Missing natspec comments * [Q-3] test fixes * forge updates * fix claim quantity limit * add test * run prettier * replace requires with custom errors replace requires with custom errors * standardize errors * update tests * run prettier * [L-6] claimCondition.startTimestamp is not enforced -- revised fix * [L-6] claimCondition.startTimestamp is not enforced * reorganize errors and checks * 0xMacro audit Jun '22: Multiwrap (#181) * [H-1] Wrapped ETH cannot be unwrapped * [L-1] Anyone can call renounceRole(), and delete the first valid entry from roleMembers for any role * [L-2] Incorrect supportsInterface implementation * [G-4] Require revert msg string length > 32 for Multiwrap: L176 (edited) * [G-3] Optimization done in CurrencyTransferLib for rare edge cases, increases gas costs for all other use cases. * [G-2] Improvements for _setBundle() * [L-7] Unsafe usage of msg.value within CurrencyTransfer library * [G-5] Return early in PermissionsEnumerable#getRoleMember Co-authored-by: Krishang Nadgauda <[email protected]> * 0xMacro audit Jun '22: DropERC1155 (#182) * (Q-1) Unused variable * fix claim quantity limit fix claim quantity limit * cleanup * remove thirdwebfee remove thirdwebfee Co-authored-by: Krishang Nadgauda <[email protected]> Co-authored-by: yash <[email protected]> Co-authored-by: Krishang Nadgauda <[email protected]> * custom errors cleanup mega commit * delete commented require statements * fix timestamp check * run prettier * REVERT G-3: breaks Marketplace * Change revert test -> balances test post behaviour fix * Fix faulty >= to > * package bump * package release * add bot check to SigDrop * fix forge build errors * Update permissions usage in pack tests * run prettier * pack docs update Co-authored-by: yash <[email protected]> Co-authored-by: Krishang Nadgauda <[email protected]> Co-authored-by: Krishang Nadgauda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.