This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Pin Swift-Benchmark to a specific revision for a consistent release. #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: #640 |
|
Alternative idea: maybe we should just tag 0.1 for swift-benchmark instead of using hashes? |
|
I think for going forward, that makes sense. for the S4TF v0.11 release, I think pinning to a specific commit is probably the best, as we need a commit that's not the latest. |
shabalind
approved these changes
Jul 21, 2020
BradLarson
added a commit
that referenced
this pull request
Aug 19, 2020
* Pin Swift-Benchmark to a specific revision for a consistent release. (#641) * Change adds functionality to GPT2 checkpoint writing. Two of the layers were missing in the writing process. Also added copy facility to the FileSystem protocol to copy the auxiliary files to the checkpoint location. Co-authored-by: Brennan Saeta <[email protected]> Co-authored-by: Brad Larson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.