This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Pin swift-benchmark to a specific revision. #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift-Benchmark currently has an unstable API. This change pins Swift-Benchmark to an explicit revision to ensure stable builds.
ematejska
approved these changes
Jul 20, 2020
|
Is this a duplicate of #641 ? |
|
Edit: It's not, the two PRs are for different branches (master vs tensorflow-0.11). |
|
@shabalind - Just checking on the status, did we need to modify this to bring it in? |
shabalind
approved these changes
Jul 30, 2020
|
@BradLarson Changes here look good to me! We should probably do a 0.1 release on swift-benchmark some time soon to make it a bit more user friendly than a particular commit hash. |
|
+1 to doing a 0.1 release. Things seem reasonably stable presently. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift-Benchmark currently has an unstable API. This change pins
Swift-Benchmark to an explicit revision to ensure stable builds.