Replace inconnect flag with something more appropriate #108
Comments
|
It is unclear what kind of problem it tries to solve. The code suggests that it is about synchronization, but readme clearly states that a connection can not be shared between different threads. If it is something Windows-related, we need to create a test case. It looks now that, if we'll just remove this flag, things will work well. |
Closed
Totktonada
added a commit
that referenced
this issue
Mar 18, 2019
There are cases when this flag is not set appropriately, that lead to a reconnection stuck: at least the case that was fixed in the commit 'Fix stuck autoreconnect case'. To more on that, this flag was only needed to workaround Windows-related bug with broken socket liveness check. Now it is fixed, so it is safe to remove it. Fixes #108.
Merged
Totktonada
added a commit
that referenced
this issue
Mar 18, 2019
There are cases when this flag is not set appropriately, that lead to a reconnection stuck: at least the case that was fixed in the commit 'Fix stuck autoreconnect case'. To more on that, this flag was only needed to workaround Windows-related bug with broken socket liveness check. Now it is fixed, so it is safe to remove it. Fixes #108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, create a lock object for controlling recursion and add wrap locking/unlocking into decorator around
connect/opt_reconnectThe text was updated successfully, but these errors were encountered: