Skip to content

Add testing on Windows #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Totktonada opened this issue Mar 14, 2019 · 0 comments
Closed

Add testing on Windows #126

Totktonada opened this issue Mar 14, 2019 · 0 comments
Assignees
@Totktonada
Labels
testing

Comments

@Totktonada
Copy link
Member

Totktonada commented Mar 14, 2019 •
edited
Loading

Use AppVeyor? Example: https://github.com/msgpack/msgpack-python/blob/381c2eff5f8ee0b8669fd6daf1fd1ecaffe7c931/appveyor.yml

Reason: The connector has Windows-related code. There are some Windows-specific fixes. We need to ensure we don't break anything in a scope of, say, #108.
@Totktonada Totktonada self-assigned this Mar 14, 2019
Totktonada added a commit that referenced this issue Mar 18, 2019
@Totktonada
WIP: Add Windows CI
e335cc6 
Rewrote admin_connection.py to reconnect on a sendall() error, because
checking socket liveness does not work under Windows.

Fixes #126.
Totktonada added a commit that referenced this issue Mar 18, 2019
@Totktonada
Add Windows CI (AppVeyor)
65c450d 
Rewrote admin_connection.py to reconnect on a sendall() error, because
checking of a socket liveness does not work under Windows.

Fixes #126.
@Totktonada Totktonada mentioned this issue Mar 18, 2019
Merged
Totktonada added a commit that referenced this issue Mar 18, 2019
@Totktonada
Add Windows CI (AppVeyor)
e2e32ab 
Rewrote admin_connection.py to reconnect on a sendall() error, because
checking of a socket liveness does not work under Windows.

Fixes #126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Totktonada Totktonada

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Totktonada