Fix stuck reconnection #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we call ping() at a not connected socket the following call trace
is proceeded: ping() -> _send_request() -> _opt_reconnect() -> {here
self.socket is None} -> connect() -> {inconnect is set to True} ->
connect_basic() -> connect_tcp() -> raise NetworkError -> fall though
try-except in connect() -> use null self._socket when try to send a
packet.
A test case ('test_01_simple') will be added within the following
commit.
There are cases when this flag is not set appropriately, that lead to a reconnection stuck: at least the case that was fixed in the commit 'Fix stuck autoreconnect case'. To more on that, this flag was only needed to workaround Windows-related bug with broken socket liveness check. Now it is fixed, so it is safe to remove it. Fixes #108.
Totktonada
force-pushed
the
Totktonada/gh-125-add-reconnection-test
branch
from
f67a5c1 to
9ccd0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108.
Fixes #125.