Update cloud account URL to upsert #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
non-blocker suggestion; having a test that validates subsequent registries on same account |
|
@wideawakening , can we actually confirm first if the management cloud account is already created in whatever instance the test suit runs on? It may be possible that the management cloud account was previously created and never destroyed, which would explain the conflict. Also we may want to confirm that nothing in the test suite depends on the management cloud account always existing, though that seems unlikely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL needs to include
upsertquery param to upsert a cloud account if it already exists, avoiding 409 conflict