-
Notifications
You must be signed in to change notification settings - Fork 27
feat: enable benchmark on organizational management account #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
variable "provision_in_management_account" { | ||
type = bool | ||
default = true | ||
description = "Whether to deploy the stack in the management account" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess we can hold exposing this variable to the examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
doing some maintenance on module so will add the "cft stackset instance" to managed account on diagrams too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @aq17!
i was iterating this yesterday and got 409 cloud-account setup conflict over and over again thinking it may be due to other causes, but after properly passing checks on other PR's (with some cleanup).. i'm thinking there may be something wrong with these changes. been digging on the some non-critical code review
|
Is the 409 for all accounts or specifically the master account? |
# Conflicts: # examples/organizational/README.md # examples/single-account/README.md
fix for tests through the provider running smoothly |
Previously, the organizational example did not create a cloud account and include the management account in the benchmark task scope