feat: cloudconnector deployment on AppRunner #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aws-secure-for-cloud into feat-apprunner-poc
penguinjournals
changed the title
penguinjournals
requested review from
wideawakening
and removed request for
wideawakening
…aws-secure-for-cloud into feat-apprunner-poc
…aws-cloudvision into feat-apprunner-poc
…aws-secure-for-cloud into feat-apprunner-poc
…aws-secure-for-cloud into feat-apprunner-poc
README.md
Outdated
| ## Usage | ||
|
|
||
| - There are several ways to deploy this in you AWS infrastructure, gathered under **[`/examples`](./examples)** | ||
| - [Single Account](#--single-account) |
There was a problem hiding this comment.
| ### - Single-Account on AppRunner | ||
|
|
||
| Sysdig workload will be deployed using AppRunner in the same account where user's resources will be watched.<br/> | ||
| More info in [`./examples/single-account-apprunner`](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/examples/single-account-apprunner) |
There was a problem hiding this comment.
i would point all diagrams to master already, or you're gonna need an extra PR for that :D
|
almost ready to go @penguinjournals ! left you some comments for changes ( edited the main description to add side-quest changes for clarification and for next iteration we need to sync apprunner with #84 and disable scanning by default. but that for another PR :D |
README.md
Outdated
| If you already own a Kubernetes Cluster on AWS, you can use it to deploy Sysdig Secure for Cloud, instead of default ECS cluster.<br/> | ||
| More info in [`./examples/single-account-k8s`](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/examples/single-account-k8s) | ||
|
|
||
|  |
There was a problem hiding this comment.
this one to master too :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: deploy cloudconnector on apprunner
side-quest