IRGen: Mark some llvm::APInt constructions as signed
#83854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an assertion failure in the rebranch `llvm::APInt` ctor on 32-bit Windows. We were hitting the assertion because `uint64_t(-2)` does not fit into 32 bits when treated as unsigned. These assertions were enabled by default llvm/llvm-project#114539.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
|
I can confirm this fixes the issue in my local build. |
Steelskin
approved these changes
Aug 21, 2025
|
@swift-ci please test Windows |
1 similar comment
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
|
(was on the lldb timeout issue) |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an assertion failure in the rebranch
llvm::APIntctor on 32-bit Windows. We were hitting the assertion becauseuint64_t(-2)does not fit into 32 bits when treated as unsigned.These assertions were enabled by default llvm/llvm-project#114539.
Resolves #83849.