IRGen: Restore implicit truncation in some calls to llvm::APInt ctor
#83842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #81464. Fixes an assertion failure on 32-bit Windows. The default value was flipped in llvm/llvm-project#114539.
|
@swift-ci please smoke test |
rjmccall
reviewed
Aug 21, 2025
| llvm::Constant *NegativeOne = llvm::Constant::getIntegerValue( | ||
| IntPtrTy, APInt(IntPtrTy->getBitWidth(), -2)); | ||
| IntPtrTy, APInt(IntPtrTy->getBitWidth(), -2, /*isSigned*/ false, | ||
| /*implicitTrunc*/ true)); |
There was a problem hiding this comment.
This should pass /*isSigned*/ true. If IntPtrTy->getBitWidth() were actually huge, we would in fact want this to be sign-extended, and it also fixes the assertion without needing to pass implicitTrunc because it's okay to truncate consistent sign bits. (This also means you can just make the change on main.)
Also, I don't think this is on you to fix, but how did we end up with a variable called NegativeOne that represents a value of -2?
There was a problem hiding this comment.
Thanks!
how did we end up with a variable called NegativeOne that represents a value of -2
68bc33fed32#diff-e3cb1b9416734345839b90f1c5ec26d9173d335e687abb007c9ec0b332b3d3e4
cc @compnerd
|
Superseded by #83854. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #81464. Fixes an assertion failure on 32-bit Windows.
The default value was flipped in llvm/llvm-project#114539.